Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds infoblox maintainers #1327

Closed
wants to merge 1 commit into from
Closed

Adds infoblox maintainers #1327

wants to merge 1 commit into from

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented Dec 18, 2019

This is an attempt at fixing #1317 while experimenting with OWNERS file. I'm not too familiar myself, but this is how I understand it should work given https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md .

/cc @njuettner

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2019
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the kubernetes-sigs org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • saileshgiri
    • provider/OWNERS

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 18, 2019
@njuettner
Copy link
Member

@Raffo it seems @saileshgiri needs to be a part of the kubernetes-sigs org 😞.

@Raffo
Copy link
Contributor Author

Raffo commented Dec 19, 2019

Yeah I've seen it. I wonder how we can proceed: does it even scale to add all maintainers to the org? Maybe a one off thing can pass, but that isn't really feasible.

@Raffo
Copy link
Contributor Author

Raffo commented Feb 4, 2020

Closing as we figured that this is not a valid approach.

@Raffo Raffo closed this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants