Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new provider: Akamai FastDNS #1384

Merged
merged 4 commits into from
Jan 23, 2020
Merged

Added new provider: Akamai FastDNS #1384

merged 4 commits into from
Jan 23, 2020

Conversation

KarstenSiemer
Copy link
Contributor

Hello,
this is the pull request for this proposal: #1338
This is my first project in go, so any criticism is greatly appreciated.
The code is currently running in production and is managing hundreds of endpoints.
I failed to find any bugs yet, but will happily support the code in the future in case something needs to change.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 21, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @KarstenSiemer!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 21, 2020
@KarstenSiemer
Copy link
Contributor Author

signed CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 21, 2020
@KarstenSiemer KarstenSiemer changed the base branch from master to v0.5.17 January 21, 2020 10:07
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍. I added some comments.

I also saw you want to merge it into the wrong branch, please always use Master as your target branch.

provider/akamai.go Outdated Show resolved Hide resolved
provider/akamai.go Outdated Show resolved Hide resolved
provider/akamai.go Outdated Show resolved Hide resolved
@KarstenSiemer
Copy link
Contributor Author

KarstenSiemer commented Jan 21, 2020

Hi thanks for the quick answer! 👍
I should have forked from master, currently working on a rebase :-)

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2020
@KarstenSiemer KarstenSiemer changed the base branch from v0.5.17 to master January 21, 2020 13:24
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 21, 2020
@KarstenSiemer
Copy link
Contributor Author

Done :-)
Addressed comments, rebased and the travis ci build passed.
And I retested all functionality in a production kubernetes cluster.

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request, you may want to add a tutorial (see docs) which shows users how to run this provider.
Also please add to the README.MD and set it as alpha for now.

Thank you so much for providing Akamai FastDNS as a new provider 👍

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2020
@njuettner njuettner added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 432d069 into kubernetes-sigs:master Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KarstenSiemer, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KarstenSiemer KarstenSiemer deleted the Add_new_Provider-Akamai_FastDNS branch January 24, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants