Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement annotation filter for CRD source #1399

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Implement annotation filter for CRD source #1399

merged 1 commit into from
Apr 7, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jan 28, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2020
ytsarev added a commit to k8gb-io/k8gb that referenced this pull request Jan 28, 2020
@ytsarev
Annotation filtering for DNSEndpoints
42fddb2 
* Distinguish between local and edge dns types
* Use custom external-dns build until upstream accept the
  kubernetes-sigs/external-dns#1399
ytsarev added a commit to k8gb-io/k8gb that referenced this pull request Jan 29, 2020
@ytsarev
Initial Edge DNS support (#36)
86d6c59 
* Debug and make helpers

* Initial Edge DNS support

* Dedicated DNSEndpoint to manage A records for NS servers pointing
  to GSLB
* Initial Infoblox support

* Annotation filtering for DNSEndpoints

* Distinguish between local and edge dns types
* Use custom external-dns build until upstream accept the
  kubernetes-sigs/external-dns#1399

* Bump version

* sslVerify control for external-dns infoblox deployment
@ytsarev
Copy link
Member Author

ytsarev commented Feb 5, 2020

@hjacobs , @njuettner guys, any feedback ?

@ytsarev
Copy link
Member Author

ytsarev commented Feb 12, 2020

@hjacobs , @njuettner the change is non-intrusive, covered by tests and tested out in real environment. Any chance we can merge it in soon?

@ytsarev
Copy link
Member Author

ytsarev commented Mar 2, 2020

@hjacobs , @njuettner any update ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2020
@ytsarev
Copy link
Member Author

ytsarev commented Mar 19, 2020

Hi @Raffo , could you please look into this one ? Is anything blocking the merge ? Thanks in advance.

@Raffo
Copy link
Contributor

Raffo commented Mar 19, 2020

I'm gonna try to work on the backlog on the weekend. Unfortunately those times aren't exactly normal, so my availability isn't great (not that it was before 😄).

@ytsarev
Copy link
Member Author

ytsarev commented Mar 19, 2020

@Raffo that would be amazing, thanks :)

@Raffo
Copy link
Contributor

Raffo commented Mar 26, 2020 •
edited
Loading

@ytsarev It looks like tests are broken, can you take a look?

@ytsarev
Implement annotation filter for CRD source
d432625 
* Ability to use `--annotation-filter` for CRD source
* Use case is similar to https://github.com/kubernetes-sigs/external-dns/blob/master/docs/faq.md#running-an-internal-and-external-dns-service
  but for CRD source, effectively DNSEndpoints instead of Ingresses
@ytsarev
Copy link
Member Author

ytsarev commented Mar 27, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@ytsarev: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ytsarev
Copy link
Member Author

ytsarev commented Mar 27, 2020

@Raffo tests were broken due to unrelated problems inside the new ovh provider. I fixed it there #1469 . PR is rebased, but it looks like I cannot retrigger the full pipeline run. Now it should be ok though.

Thanks a lot for looking into it, especially at current crazy times.

@ytsarev
Copy link
Member Author

ytsarev commented Apr 2, 2020

/assign @linki

Raffo
Raffo approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, ytsarev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit b6078df into kubernetes-sigs:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raffo Raffo Raffo approved these changes

@hjacobs hjacobs Awaiting requested review from hjacobs

@njuettner njuettner Awaiting requested review from njuettner

Assignees

@linki linki

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ytsarev @Raffo @k8s-ci-robot @linki