Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Docker build instructions to the README #1408

Closed
wants to merge 1 commit into from

Conversation

cpaika
Copy link

@cpaika cpaika commented Feb 5, 2020

I was looking through the README on how to build External-DNS - I was assuming I had to do a build with make, and then do a docker build. Did the docker build and realized that the Dockerfile had a build container that handled building the source code.

Feel free to reject and let me know if it's too obvious for a README - I'm new to the K8's ecosystem馃槃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 5, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @cpaika!

It looks like this is your first PR to kubernetes-sigs/external-dns 馃帀. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 馃槂

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpaika
To complete the pull request process, please assign hjacobs
You can assign the PR to them by writing /assign @hjacobs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpaika
Copy link
Author

cpaika commented Feb 5, 2020

Looks like the Linux CLA signup process is broken temporarily? Waiting on a confirmation email from HelloSign 馃槂

@njuettner
Copy link
Member

@cpaika It seems the CLA is still missing do you mind checking it again? Please verify the email for your commit is the same you did sign the CLA. If you think everything is correct, you can try to use this command: https://prow.k8s.io/command-help?repo=kubernetes-sigs%2Fexternal-dns#check_cla.

@njuettner
Copy link
Member

Feel free to reopen the PR once you have signed the CLA

@njuettner njuettner closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants