New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Docker build instructions to the README #1408
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 馃摑 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @cpaika! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cpaika The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like the Linux CLA signup process is broken temporarily? Waiting on a confirmation email from HelloSign 馃槂 |
@cpaika It seems the CLA is still missing do you mind checking it again? Please verify the email for your commit is the same you did sign the CLA. If you think everything is correct, you can try to use this command: https://prow.k8s.io/command-help?repo=kubernetes-sigs%2Fexternal-dns#check_cla. |
Feel free to reopen the PR once you have signed the CLA |
I was looking through the README on how to build External-DNS - I was assuming I had to do a build with
make
, and then do a docker build. Did the docker build and realized that the Dockerfile had a build container that handled building the source code.Feel free to reject and let me know if it's too obvious for a README - I'm new to the K8's ecosystem馃槃