fix(azure): not use SPN to authenticate when clientid or secret is 'msi' #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
njuettner
requested changes
Feb 12, 2020
k8s-ci-robot
added
size/M
Add unit test Fix unit test error Fix unit test error Fix unit test error Fix unit test error Fix unit test error Fix unit test error Fix unit test error
k8s-ci-robot
added
the
lgtm
|
@njuettner could you help to review the changes again? |
|
/area provider/azure |
k8s-ci-robot
added
the
area/provider/azure
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, norshtein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some historical reason, for clusters using managed identity, they will use "msi" as placeholder in azure.json. In this case, we shouldn't try to use SPN to authenticate.