-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete orphaned owned TXT record #1503
Conversation
This allows removing of records and creating them in one operation.
When using the TXT registry it can sometimes happen that the A record is removed but the TXT record not. In that case, external-dns will try to recreate the missing A record. It will blindly also create a new TXT record. But that record already exists. The operation will fail and the A record won't be created until the TXT record is also removed. With this change, the existing TXT record will be removed before creating it again.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @ruudk! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ruudk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ruudk: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Fixes #1502
When using the TXT registry it can sometimes happen that the A record is removed but the TXT record not. This could be caused by a human for example.
In that case, external-dns will try to recreate the missing A record. It will blindly also create a new TXT record. But that record already exists. The operation will fail and the A record won't be created until the TXT record is also removed. See #1502 for full details.
With this change, the existing TXT record will be removed before creating it again.
I will add tests once it is agreed that this is the right way to go.
Todo