Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updates in CloudFlare provider #1542

Merged
merged 9 commits into from
May 16, 2020
Merged

Fix updates in CloudFlare provider #1542

merged 9 commits into from
May 16, 2020

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Apr 22, 2020

This pull request fixes update logic bugs from #1514

#1537 should be merged before this PR is merged. For actual changes please see just last commit

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2020
@sheerun sheerun changed the title Fix updates Fix updates in CloudFlare provider Apr 22, 2020
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 22, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 22, 2020
@sheerun
Copy link
Contributor Author

sheerun commented Apr 22, 2020

/assign @linki

This was referenced Apr 22, 2020
Closed
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2020
@TheUltimateC0der
Copy link

Since #1537 is merged now. Can you do the rabase now @sheerun ? Would really appreciate this fix!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 4, 2020
@sheerun
Copy link
Contributor Author

sheerun commented May 4, 2020

@TheUltimateC0der @Raffo @linki This PR should be ready to review

@jasoares
Copy link

jasoares commented May 8, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jasoares: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2020
@sheerun
Copy link
Contributor Author

sheerun commented May 11, 2020

rebased and ready to review

@sheerun
Copy link
Contributor Author

sheerun commented May 13, 2020

/assign @Raffo

@TheUltimateC0der
Copy link

@Raffo @linki Would be awesome if you could look into this!

Raffo
Raffo reviewed May 16, 2020
View reviewed changes
provider/provider.go Outdated Show resolved Hide resolved
Raffo
Raffo reviewed May 16, 2020
View reviewed changes
Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few minor comments, changes look good to me.

provider/provider_test.go Show resolved Hide resolved
provider/provider.go Outdated Show resolved Hide resolved
provider/cloudflare/cloudflare.go Show resolved Hide resolved
@sheerun
Copy link
Contributor Author

sheerun commented May 16, 2020

@Raffo I've addressed your suggestions :)

Raffo
Raffo approved these changes May 16, 2020
View reviewed changes
Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, sheerun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3db7f99 into kubernetes-sigs:master May 16, 2020
@sheerun
Copy link
Contributor Author

sheerun commented May 16, 2020

@Raffo Just FYI updates aren't fixed 100% until #1536 is merged, because failure in record comparison causes repeated updates

@renehernandez renehernandez mentioned this pull request Oct 6, 2021
Closed
2 tasks
@renehernandez renehernandez mentioned this pull request Jun 2, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raffo Raffo Raffo approved these changes

@TheUltimateC0der TheUltimateC0der TheUltimateC0der approved these changes

@linki linki Awaiting requested review from linki

Assignees

@linki linki

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sheerun @TheUltimateC0der @jasoares @k8s-ci-robot @Raffo @NicklasWallgren @linki