Fix #1540 source: explicitly handle default annotations

[squat]

This commit fixes a bug that causes the Cloudflare provider to delete
and recreate all records every minute.
The controller is running into trouble when reconciling endpoints with
values with implicit defaults. This is caused because the providers
produce records with all values explicitly set, however the sources
generate endpoints with implicit provider-specific values, i.e. when an
annotation is not set. This causes the planner to always detect a diff.

Fixes: #1540

Signed-off-by: Lucas Servén Marín lserven@gmail.com

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: squat
To complete the pull request process, please assign hjacobs
You can assign the PR to them by writing /assign @hjacobs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @squat!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[squat]

ping @sheerun, since you are the new owner for the cloudflare provider :)
This PR fixes #1540. This is now rebased since the latest cloudflare changes were merged in the last day

[sheerun]

@squat #1536 fixes this issue in more generalized way, allowing custom comparators

[squat]

sounds good, I didn't want to go that route to avoid adding extra complexity to the system but I am happy with simply having a fix. Let's close 1540 as a dupe of 1463 for better visibility and you can close this PR if you like (:

[k8s-ci-robot]

@squat: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Raffo]

Should we close this one @sheerun ?

[sheerun]

Yes I think so, #1536 will be merged very soon

/close

[k8s-ci-robot]

@sheerun: Closed this PR.

In response to this:

Yes I think so, #1536 will be merged very soon

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.