Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests faster #1568

Merged
merged 1 commit into from
May 16, 2020
Merged

Make tests faster #1568

merged 1 commit into from
May 16, 2020

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented May 11, 2020

Reduces test time on travis to 4 minutes by:

  • making polling for changes faster in test environment (1 second -> 10 milliseconds)
  • preserving go mod cache directory between builds
  • disabling logs in test by default (can be overridden with DEBUG=info env variable)
  • paralleliziling linting and coverage runs on travis

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2020
@sheerun sheerun mentioned this pull request May 11, 2020
Merged
@sheerun
Copy link
Contributor Author

sheerun commented May 11, 2020

/assign @linki

@sheerun sheerun force-pushed the faster-tests branch 2 times, most recently from d391c03 to a6b5fa7 Compare May 12, 2020 13:43
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2020
@sheerun
Copy link
Contributor Author

sheerun commented May 12, 2020

Making tests as fast as possible revealed bug in code connected to checking if informers are synchronized. I've fixed it: https://github.com/kubernetes-sigs/external-dns/pull/1568/files#diff-936c9bb908c1730ea7bc92722af733deR125

@sheerun
Copy link
Contributor Author

sheerun commented May 13, 2020

/assign @Raffo

@Raffo
Copy link
Contributor

Raffo commented May 16, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, sheerun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9e6d56e into kubernetes-sigs:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjacobs hjacobs Awaiting requested review from hjacobs

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@linki linki

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sheerun @Raffo @k8s-ci-robot @linki