Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hetzner DNS service support #1570

Merged
merged 20 commits into from Jun 18, 2020
Merged

Hetzner DNS service support #1570

merged 20 commits into from Jun 18, 2020

Conversation

21h
Copy link
Contributor

@21h 21h commented May 12, 2020

I added some Hetzner support, but without tests right now. Tested on real account and it successfully works. Please review and say what you think.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 12, 2020
@k8s-ci-robot k8s-ci-robot requested review from linki and Raffo May 12, 2020 01:01
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @21h!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 12, 2020
provider/hetzner.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
provider/hetzner.go Outdated Show resolved Hide resolved
provider/hetzner.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 14, 2020
21h added 4 commits May 14, 2020 08:56
To run:

provide token HETZNER_TOKEN in ENV
set command line parameter --provider=hetzner
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2020
@miry
Copy link

miry commented May 14, 2020

@21h It looks good. I will check the code more later. Do you think you can start work on tests part?
It would great to have also some instructions how do you test changes?

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for adding a new provider to external-dns 👍. I would like you to add tests and documentation how to use it.
You can find docs in the docs folder for other provider.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2020
@21h
Copy link
Contributor Author

21h commented May 17, 2020

Hi thanks for adding a new provider to external-dns . I would like you to add tests and documentation how to use it.

I do not have much free time to make tests right now, but documentation will be soon.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 18, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2020
@21h 21h requested a review from njuettner May 25, 2020 17:57
provider/hetzner/hetzner.go Outdated Show resolved Hide resolved
@21h
Copy link
Contributor Author

21h commented May 27, 2020

I am not kubernetes author, but let it be written like this

added license as in other files

@21h 21h requested a review from njuettner May 29, 2020 17:44
@21h
Copy link
Contributor Author

21h commented Jun 4, 2020

@njuettner ping

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits and then we're good to go 🚀

docs/tutorials/hetzner.md Outdated Show resolved Hide resolved
docs/tutorials/hetzner.md Outdated Show resolved Hide resolved
docs/tutorials/hetzner.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2020
@21h
Copy link
Contributor Author

21h commented Jun 9, 2020

@njuettner

merge

@21h 21h requested a review from njuettner June 11, 2020 06:17
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

image

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 21h, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0f186d3 into kubernetes-sigs:master Jun 18, 2020
@codeagencybe
Copy link

@21h
Hello

Could you create working integration for ClouDNS also? Does it take a lot of work?
https://cloudns.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants