Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation about rfc2136 TTLs #1581

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

stefanlasiewski
Copy link
Contributor

Now that --rfc2136-min-ttl is an option, show how to set it and also how to override it using an annotation.

Now that `--rfc2136-min-ttl` is an option, show how to set it and also how to override it using an annotation.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 15, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @stefanlasiewski!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 15, 2020
@sheerun
Copy link
Contributor

sheerun commented May 16, 2020

@stefanlasiewski Could you accept CLA?

@stefanlasiewski
Copy link
Contributor Author

I need to get approval before I can sign the agreement, and I hope that will happen soon.

@JoaoBraveCoding
Copy link
Contributor

I think you have a typo in the name of the MR, rfc2126 -> rfc2136

@stefanlasiewski
Copy link
Contributor Author

I need to get approval before I can sign the agreement, and I hope that will happen soon.

Just FYI, I am still waiting for approval.

@stefanlasiewski stefanlasiewski changed the title Improve documentation about rfc2126 TTLs Improve documentation about rfc2136 TTLs Jun 16, 2020
@stefanlasiewski
Copy link
Contributor Author

I think you have a typo in the name of the MR, rfc2126 -> rfc2136

Thank you for catching that. Fixed.

@seanmalloy
Copy link
Member

@stefanlasiewski any luck getting the CLA signed?

@stefanlasiewski
Copy link
Contributor Author

No, not yet, unfortunately.

@seanmalloy
Copy link
Member

No, not yet, unfortunately.

@stefanlasiewski let me know if there is anything I can do to assist with this. Thanks!

@stefanlasiewski
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 31, 2020
@seanmalloy
Copy link
Member

/lgtm
/assign @Raffo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2020
@seanmalloy
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 16, 2020
@Raffo
Copy link
Contributor

Raffo commented Aug 17, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, stefanlasiewski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1e2b11d into kubernetes-sigs:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants