-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use porscheinformatik-images because zalando/teapot isn't built timely #1586
Use porscheinformatik-images because zalando/teapot isn't built timely #1586
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jgrumboe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @njuettner |
/unassign @njuettner |
@jgrumboe thanks for your PR, we probably forgot to update the how to docs for each provider but we moved away from this registry. We use now the official registry for all kubernetes sigs projects see in our releases. Here are latest images for each region:
|
@njuettner Do I understand it correctly that images are only built after releasing a new version, so there's no :latest tag after each merged commit? |
I'd love to get us to a point in which we own nightly builds rather than having a single organization owning the release process. Being the release process for the official builds a bit of a pain, we should keep the ones mentioned by @njuettner for stable release and something else for nightly builds. For that reason, I'm against this change and rather for fixing the underlying problem. |
It looks like each commit to master gets built and pushed to the staging registry for external-dns. Here is the command to list all of the tags in the staging registry. These would be equivalent-ish to night builds and not stable releases.
I hope that helps. |
Oh that's sweet I didn't even know that! I'll keep this issue around to document that behavior, close it when done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@njuettner Do I understand it correctly that images are only built after releasing a new version, so there's no :latest tag after each merged commit?
If so, I would like to stick with porscheinformatik images for the openshift tutorial until a new version is released.
Correct 🙂 , but as @seanmalloy pointed out you can also use the staging external-dns source, which will create for each PR an image which you could use as a kind of night build.
Or you can use this link (but this needs probably an google account):
https://console.cloud.google.com/gcr/images/k8s-staging-external-dns/GLOBAL/external-dns?gcrImageListsize=30
@@ -25,7 +25,7 @@ spec: | |||
spec: | |||
containers: | |||
- name: external-dns | |||
image: registry.opensource.zalan.do/teapot/external-dns:latest | |||
image: docker.io/porscheinformatik/external-dns:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change it to the official registry as I mentioned in my comment 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@njuettner I understand. But wouldn't the kubernetes-staging image be better, since as long as no new release is released new users would try an image which doesn't reflect the new capability.
/hold |
I would like to change the tutorial for openshift-route source to use images from docker.io/porscheinformatik/external-dns, because I currently don't know when the images for registry.opensource.zalan.do/teapot/external-dns are built.
Furthermore it would be good to have images in an "official" kubernetes-sigs registry, if such exists.