Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use porscheinformatik-images because zalando/teapot isn't built timely #1586

Conversation

jgrumboe
Copy link
Contributor

I would like to change the tutorial for openshift-route source to use images from docker.io/porscheinformatik/external-dns, because I currently don't know when the images for registry.opensource.zalan.do/teapot/external-dns are built.

Furthermore it would be good to have images in an "official" kubernetes-sigs registry, if such exists.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgrumboe
To complete the pull request process, please assign hjacobs
You can assign the PR to them by writing /assign @hjacobs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2020
@jgrumboe
Copy link
Contributor Author

/assign @njuettner

@jgrumboe
Copy link
Contributor Author

/unassign @njuettner
/assign @hjacobs

@k8s-ci-robot k8s-ci-robot assigned hjacobs and unassigned njuettner May 18, 2020
@njuettner
Copy link
Member

@jgrumboe thanks for your PR, we probably forgot to update the how to docs for each provider but we moved away from this registry. We use now the official registry for all kubernetes sigs projects see in our releases.

Here are latest images for each region:

docker run asia.gcr.io/k8s-artifacts-prod/external-dns/external-dns:v0.7.1 --help
docker run eu.gcr.io/k8s-artifacts-prod/external-dns/external-dns:v0.7.1 --help
docker run us.gcr.io/k8s-artifacts-prod/external-dns/external-dns:v0.7.1 --help

@jgrumboe
Copy link
Contributor Author

jgrumboe commented May 18, 2020

@njuettner Do I understand it correctly that images are only built after releasing a new version, so there's no :latest tag after each merged commit?
If so, I would like to stick with porscheinformatik images for the openshift tutorial until a new version is released.

@Raffo
Copy link
Contributor

Raffo commented May 18, 2020

I'd love to get us to a point in which we own nightly builds rather than having a single organization owning the release process. Being the release process for the official builds a bit of a pain, we should keep the ones mentioned by @njuettner for stable release and something else for nightly builds. For that reason, I'm against this change and rather for fixing the underlying problem.

@seanmalloy
Copy link
Member

seanmalloy commented May 21, 2020

It looks like each commit to master gets built and pushed to the staging registry for external-dns.

Here is the command to list all of the tags in the staging registry. These would be equivalent-ish to night builds and not stable releases.

gcloud container images list-tags gcr.io/k8s-staging-external-dns/external-dns

I hope that helps.

@Raffo
Copy link
Contributor

Raffo commented May 21, 2020

Oh that's sweet I didn't even know that! I'll keep this issue around to document that behavior, close it when done.

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njuettner Do I understand it correctly that images are only built after releasing a new version, so there's no :latest tag after each merged commit?
If so, I would like to stick with porscheinformatik images for the openshift tutorial until a new version is released.

Correct 🙂 , but as @seanmalloy pointed out you can also use the staging external-dns source, which will create for each PR an image which you could use as a kind of night build.

Or you can use this link (but this needs probably an google account):
https://console.cloud.google.com/gcr/images/k8s-staging-external-dns/GLOBAL/external-dns?gcrImageListsize=30

@@ -25,7 +25,7 @@ spec:
spec:
containers:
- name: external-dns
image: registry.opensource.zalan.do/teapot/external-dns:latest
image: docker.io/porscheinformatik/external-dns:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to the official registry as I mentioned in my comment 🙂

Copy link
Contributor Author

@jgrumboe jgrumboe May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njuettner I understand. But wouldn't the kubernetes-staging image be better, since as long as no new release is released new users would try an image which doesn't reflect the new capability.

@jgrumboe
Copy link
Contributor Author

/hold
@Raffo @njuettner I will wait for the next release and update the image link to eu.gcr.io/k8s-artifacts-prod/external-dns/external-dns:WHAT-EVER-NEW-VERSION.
Wouldn't it be great to have a "latest" tag? (https://console.cloud.google.com/gcr/images/k8s-artifacts-prod/EU/external-dns/external-dns?gcrImageListsize=30)
"latest" would make sense for the tutorials.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2020
@jgrumboe jgrumboe closed this Aug 18, 2020
@jgrumboe jgrumboe deleted the porscheinformatik-image-url branch August 28, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants