digitalocean: increase API page size

[tdyas]

The default API page size for the DigitalOcean API is 20 objects. Increase to 200 to reduce the number of API calls required to enumerate domains and records. Should fix #1429.

[tdyas]

/assign @njuettner

[Raffo]

@tdyas thank you for your PR! Would you be able to tell me what are the consequences in terms of usage of the API or performance to increase such value? Wouldn't it be better to make it configurable via a flag or is it generally safe to have 200 as default?

[tdyas]

I used 200 mainly because it is used in the DigitalOcean Terraform provider (see https://github.com/terraform-providers/terraform-provider-digitalocean/blob/fd9e7b8b8156599799c7b2e636f68a529929b3bf/digitalocean/datasource_digitalocean_sizes.go#L88 for an example), and is one order of magnitude up from the default of 20.

I'd be fine with making it configurable though. My external-dns deployment is not at the scale where I would be able to see it make it difference or not. Thus making it configurable would allow people with deployments at that scale to tune it to their needs.

[njuettner]

@tdyas as Raffo said please make it configurable 🙂. People like to like at the options of their preferred provider. The less hardcoded stuff we have the better it is for us to maintain it.

[tdyas]

@tdyas as Raffo said please make it configurable slightly_smiling_face. People like to like at the options of their preferred provider. The less hardcoded stuff we have the better it is for us to maintain it.

Makes sense. The latest commits make it configurable via --digitalocean-api-page-size. It also sets the default at 50 instead of 200. (The godo DigitalOcean API library uses a default of 20.)

[njuettner]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, tdyas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [njuettner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment