Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm chart to use v0.10.1 #2395

Merged

Conversation

stevehipwell
Copy link
Contributor

Description
This PR updates the Helm chart to use the latest v0.10.1 release.

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2021
@stevehipwell
Copy link
Contributor Author

/assign @Raffo

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2021
@stevehipwell
Copy link
Contributor Author

@Raffo it looks like we're waiting on the Docker image build?

docker pull k8s.gcr.io/external-dns/external-dns:v0.10.1

@Raffo
Copy link
Contributor

Raffo commented Oct 22, 2021

@stevehipwell yes, the whole process takes roughly one day 😅

@stevehipwell
Copy link
Contributor Author

@Raffo sorry for jumping the gun. It should just be a case of running the failed action once the image has been built.

@Raffo
Copy link
Contributor

Raffo commented Oct 22, 2021

No worries, I can re run and merge when we are ready.

@Raffo
Copy link
Contributor

Raffo commented Oct 22, 2021

Actually we have a new bug in the release process: #2396 . I'll keep this open, delete release v0.10.0 and re-release it as soon as this bug is fixed.

@stevehipwell
Copy link
Contributor Author

Actually we have a new bug in the release process: #2396 . I'll keep this open, delete release v0.10.0 and re-release it as soon as this bug is fixed.

@Raffo I assume you mean delete release v0.10.1?

@Raffo
Copy link
Contributor

Raffo commented Oct 22, 2021

Yes sorry.

@Raffo
Copy link
Contributor

Raffo commented Oct 23, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 665ab3c into kubernetes-sigs:master Oct 23, 2021
@stevehipwell stevehipwell deleted the helm-chart-v0-10-1 branch October 25, 2021 07:54
@stevehipwell
Copy link
Contributor Author

Thanks for getting this merged @Raffo.

As I'm now a member of the kubernetes-sigs organisation, would it be appropriate for me, as the chart maintainer, to open a PR to add an OWNERS file into charts with me as a reviewer/approver?

@Raffo
Copy link
Contributor

Raffo commented Oct 25, 2021

@stevehipwell yes, happy to approve such PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants