Fix CNAME record when multiple router canonical name are defined in Route Status. #2400
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
miheer
force-pushed
the
add-router-field-for-ocpRouteSource
branch
from
9cd9420
to
d4f7d08
Compare
miheer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
miheer
force-pushed
the
add-router-field-for-ocpRouteSource
branch
3 times, most recently
from
8734d6d
to
719224f
Compare
|
LGTM |
|
@seanmalloy @Raffo PTAL. Thanks in advance! |
miheer
force-pushed
the
add-router-field-for-ocpRouteSource
branch
from
719224f
to
6876a3f
Compare
|
/cc @vinny-sabatini |
miheer
force-pushed
the
add-router-field-for-ocpRouteSource
branch
4 times, most recently
from
194437b
to
208995f
Compare
|
@miheer all the code change look good. Can you also update the docs here: https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/openshift.md I believe once this PR merges external-dns will work on OCP v4.x routes, so that should be documented. Also would be good to add a section on this new CLI option |
miheer
force-pushed
the
add-router-field-for-ocpRouteSource
branch
from
208995f
to
4637ae7
Compare
…Ingress object get populated with multiple router canonical names. So in this case, the external dns tries to add multiple CNAME records for same host in the same hosted zone which is a violation of RFC 1912 and therefore is rejected by standards-compliant DNS services. This feature adds a router field to the OCP Route Source so that a user can add an ingress controller name in flag --ocp-router-name which will be used to pick up the respective routerCanonicalHostname from Route's Status Ingress Object. Signed-off-by: Miheer Salunke <miheer.salunke@gmail.com>
miheer
force-pushed
the
add-router-field-for-ocpRouteSource
branch
from
4637ae7
to
ab8a620
Compare
|
@seanmalloy PTAL . I have made the changes in the documentation. |
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
the
lgtm
|
@Raffo @njuettner PTAL. Your attention on this will be highly appreciated. Thanks in advance! |
|
@Raffo @njuettner Can you please review ? This is a blocker for working of OCP major functionality. Your urgent attention on this will be highly appreciated. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: miheer, njuettner, vinny-sabatini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Description
In OCP when you have multiple ingress controllers the route's status'es Ingress object get populated with multiple router canonical names. So in this case, the external dns tries to add multiple CNAME records for same host in the same hosted zone which is a violation of RFC 1912 and therefore is rejected by standards-compliant DNS services.
This feature adds a router field to the OCP Route Source so that a user can add an ingress controller name in flag --openshift-router-name which will be used to pick up the respective router canonical name from Route's Status Ingress Object.