Fix incorrect flag in nginx-ingress.md #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally had `dry-run=true` as the dry run flag but that doesn't work and makes external-dns fail to start. Changed to `--dry-run`.
k8s-ci-robot
added
the
cncf-cla: yes
|
Thanks for the PR! |
ffledgling
pushed a commit
to ffledgling/external-dns
that referenced
this pull request
Jan 18, 2018
Originally had `dry-run=true` as the dry run flag but that doesn't work and makes external-dns fail to start. Changed to `--dry-run`.
lou-lan
pushed a commit
to lou-lan/external-dns
that referenced
this pull request
May 11, 2022
…t options (kubernetes-sigs#245) * Add test cases for `krew install` with --archive and --manifest options * Improve formatting * ReplaceAll was added in go 1.12, but krew uses 1.11 * Rename test plugin from `test-foo` to `foo` * Use wildcard platform selector in test data * Add windows version of the test plugin for testing on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally had
dry-run=trueas the dry run flag but that doesn't work and makes external-dns fail to start. Changed to--dry-run.