Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreDNS/SkyDNS provider #246

Closed
wants to merge 0 commits into from
Closed

Conversation

istalker2
Copy link
Contributor

This PR adds support for CoreDNS through its etcd middleware.
Because the middleware is backward compatible with SkyDNS this
commit adds support for SkyDNS as well. In fact, new provider
is available under two names in CLI (coredns and skydns).

All interactions with middleware happen through etcd cluster,
whose location (URIs) is specified via --etcd CLI parameter
by default http://localhost:2379).

The provider translates CoreDNS/DkyDNS SRV records to
A/CNAME + optional TXT endpoints, when reading from etcd and
combines A/CNAME with TXT endpoints back into single SRV record
when writing it back.

Also:

  • adds github.com/coreos/etcd package to glide.yaml and vendor folder
    because it is used by the provider
  • adds "interfaces" packages and moves Registry and Provider interfaces
    declaration there. This is required in order to use registry in
    provider unit tests. Otherwise there going to be circular imports
    because provider UTests would import registry which imports providers
    back.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2017
@linki
Copy link
Member

linki commented Jun 26, 2017

Thanks for the contribution. Very interesting. We'll have a look.

@istalker2
Copy link
Contributor Author

replaced with #253. Sorry for inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants