Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShift route source: better use of route status #2579

Merged

Conversation

alebedev87
Copy link
Contributor

Description

  • Use only those ingresses (status.ingress) which admitted the route
  • Use host from status.ingress.host because it's
    • right place for the route's host
    • part of the preparation for the implementation of Route API's spec.subdomain field

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2022
@alebedev87 alebedev87 force-pushed the use-route-status-more branch 2 times, most recently from 41b3c84 to d83ecc4 Compare February 10, 2022 12:58
@alebedev87
Copy link
Contributor Author

/assign @miheer @arjunrn

@k8s-ci-robot
Copy link
Contributor

@alebedev87: GitHub didn't allow me to assign the following users: miheer, arjunrn.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @miheer @arjunrn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor Author

cc @miheer @arjunrn

Copy link
Contributor

@arjunrn arjunrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than a couple of nits and a small refactor.

docs/tutorials/openshift.md Outdated Show resolved Hide resolved
docs/tutorials/openshift.md Outdated Show resolved Hide resolved
source/openshift_route.go Outdated Show resolved Hide resolved
source/openshift_route.go Outdated Show resolved Hide resolved
@alebedev87
Copy link
Contributor Author

/assign @seanmalloy

@seanmalloy
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit c4d1f0e into kubernetes-sigs:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants