Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: fix documented valid options for logLevel #2626

Conversation

plumdog
Copy link
Contributor

@plumdog plumdog commented Feb 24, 2022

Description

Found that setting logLevel: warn did not work as the chart's README suggested and gave me an error.

$ docker run --rm k8s.gcr.io/external-dns/external-dns:v0.10.2 --log-level=warn       
time="2022-02-24T13:38:24Z" level=fatal msg="flag parsing error: enum value must be one of panic,fatal,error,warning,info,debug,trace, got 'warn'"

(I have not added trace, even though it looks like that might be a valid option)

Found:

$ 2>&1 docker run --rm k8s.gcr.io/external-dns/external-dns:v0.10.2 --help | grep -A 2 log-level
  --log-level=info               Set the level of logging. (default: info,
                                 options: panic, debug, info, warning, error,
                                 fatal

and
https://github.com/kubernetes-sigs/external-dns/blob/v0.10.2/pkg/apis/externaldns/types.go#L506

So looks like the correct value is warning not warn, so I've changed the chart's README to say that.

I could not find an existing issue for this. I have not created one, let me know if I should.

Checklist

  • Unit tests updated (n/a)
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @plumdog!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2022
@stevehipwell
Copy link
Contributor

Thanks for the PR @plumdog.

@Raffo could you approve the workflow and do the LGTM.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: plumdog, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2022
@Raffo
Copy link
Contributor

Raffo commented Feb 24, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit b1ccdfe into kubernetes-sigs:master Feb 24, 2022
@stevehipwell stevehipwell mentioned this pull request Feb 24, 2022
2 tasks
@plumdog plumdog deleted the helm-chart-log-level-fix-documented-valid-options branch February 24, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants