Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish v1.8.0 Helm chart #2689

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Publish v1.8.0 Helm chart #2689

merged 1 commit into from
Apr 13, 2022

Conversation

stevehipwell
Copy link
Contributor

Description

This PR re-runs the release of the v1.8.0 chart when merged.

Fixes #ISSUE

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@stevehipwell stevehipwell mentioned this pull request Apr 8, 2022
Merged
2 tasks
@stevehipwell stevehipwell changed the title chore[chart]: Publish v1.8.0 Publish v1.8.0 Helm chart Apr 8, 2022
@stevehipwell
Copy link
Contributor Author

@Raffo @njuettner this PR should get round the requirement to manually run a GH action to release the last chart version merged. The failing jobs shouldn't matter as the only change is adding a couple of extra chart keywords to trigger the action.

@stevehipwell
Copy link
Contributor Author

/retest failed

@k8s-ci-robot
Copy link
Contributor

@stevehipwell: No presubmit jobs available for kubernetes-sigs/external-dns@master

In response to this:

/retest failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevehipwell
Copy link
Contributor Author

/retest

@stevehipwell
Copy link
Contributor Author

/test all

@k8s-ci-robot
Copy link
Contributor

@stevehipwell: No presubmit jobs available for kubernetes-sigs/external-dns@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevehipwell
chore[chart]: Publish v1.8.0
1f1085f 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell
Copy link
Contributor Author

@Raffo @njuettner the tests are all passing, could we get this merged ASAP?

@stevehipwell
Copy link
Contributor Author

stevehipwell commented Apr 11, 2022 •
edited

As there are no actual changes I'm going to see if I can merge this.

/lgtm

EDIT - I thought that might be the case, worth a try.

@k8s-ci-robot
Copy link
Contributor

@stevehipwell: you cannot LGTM your own PR.

In response to this:

As there are no actual changes I'm going to see if I can merge this.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Raffo
Copy link
Contributor

Raffo commented Apr 13, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 47adf3a into kubernetes-sigs:master Apr 13, 2022
@stevehipwell stevehipwell deleted the publish-chart-v1-8-0 branch October 31, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevehipwell @k8s-ci-robot @Raffo