Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restrict rfc2136 kerberos password from being exposed in logs #2703

Conversation

scottd018
Copy link
Contributor

This PR simply changes the string output of a config such that the Kerberos RFC2136 sensitive values do not get logged on controller startup.

Signed-off-by: Dustin Scott sdustin@vmware.com

Description

This PR simply changes the string output of a config such that the Kerberos RFC2136 sensitive values do not get logged on controller startup.

Fixes #2702

Checklist

Unit tests and documentation update not required for this change.

  • [ X ] Unit tests updated
  • [ X ] End user documentation updated

Signed-off-by: Dustin Scott <sdustin@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2022
@scottd018
Copy link
Contributor Author

/assign @Raffo Any chance we can get this merged? Should be pretty easy to validate this one. Let me know! Thanks!

@scottd018
Copy link
Contributor Author

@njuettner @Raffo Any chance I can get review/approval on this? Trying to get this in so that I may use this for my current customer. Figured it should be pretty easy/quick to review.

@Raffo
Copy link
Contributor

Raffo commented Apr 19, 2022

@scottd018 Thanks so much for this PR, that was definitely an oversight.

@Raffo
Copy link
Contributor

Raffo commented Apr 19, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, scottd018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 01e8a2c into kubernetes-sigs:master Apr 19, 2022
@scottd018
Copy link
Contributor Author

Thanks @Raffo . Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC2136 Password is logged
3 participants