Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure provider doc refresh #2745

Merged
merged 4 commits into from
May 12, 2022
Merged

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented May 7, 2022

Description

This is an update of Azure to align it to current AKS (Kubernetes v1.22+) and document current features, such as support for AAD Pod Identities.

Updated sections with changes for consistency and readibility, such as:

  • use long --form for options in documentation, rather than short -f form, as self documenting flags are preferred for documentation.
  • document default namespace in case users may want to put ExternalDNS into a separate namespace like external-dns or kube-addons
  • Azure DNS group is now consistently called MyDnsResourceGroup
  • Update Azure doc links to multilingual URLs, not just US English (en-us) links

Fixes #2743
Fixes #2744
Fixes #2742

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 7, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: darkn3rd / name: Joaquin Menchaca (2eb88c2)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 7, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @darkn3rd!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 7, 2022
docs/tutorials/azure.md Outdated Show resolved Hide resolved
docs/tutorials/azure.md Outdated Show resolved Hide resolved
@darkn3rd
Copy link
Contributor Author

@Raffo @seanmalloy Any chance to get this reviewed and merged?

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darkn3rd, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1194461 into kubernetes-sigs:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
4 participants