Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE doc tutorial refresh #2759

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Conversation

darkn3rd
Copy link
Contributor

Description

This is an update to support cross project access to Cloud DNS zones. Before the documentation had limited utility as it documented steps that would only work in non-secure environments.

  • organize the tutorial into single project access, cross project access, deployment, and example (nginx).
  • fold workload identity under cross project access, remove duplicated content
  • change fictional domain to example.com for consistency
  • remove self-promotion blog links
  • expand on warnings and best-practices, add explanations, google doc links where appropriate

Fixes #509
Fixes #2747
Fixes #1597
Fixes #2751

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 14, 2022
@darkn3rd
Copy link
Contributor Author

Can anyone review this? It's update to clean up GKE that documents three methods to adds permissions (for single project or cross project) beyond the legacy scope based permissions.
@Raffo @seanmalloy

@darkn3rd
Copy link
Contributor Author

darkn3rd commented Jun 9, 2022

Anyone? I ran this update tutorial on new trial account with free trial credit.

@Raffo @seanmalloy

@Raffo
Copy link
Contributor

Raffo commented Jun 10, 2022

@njuettner checked that this makes sense, approving.

@Raffo
Copy link
Contributor

Raffo commented Jun 10, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darkn3rd, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit d4ef91b into kubernetes-sigs:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
3 participants