Allow providing AWS zone ID as well as domain name filter #322
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
We would find value in this contribution as well. There was some discussion around something similar in #287 but you raise a good point, which is that in this case the permissions will most likely still permit the publishing of records to both of the hosted zones anyways. I would say though, that if the flag is multi-purposed like this that it deserves an explicit call out in the documentation. |
|
Another way of fixing this issue is by implementing #327 with the added bonus of not needing to hard code the zoneId. |
|
@sean-krail One thing that #327 doesn't afford is if you have multiple private hosted zones with the same name, peered to VPCs differently. While I agree that a simple flag for some cases is warranted, it does still make sense to have the ability to very explicitly declare this attribute as the filter |
|
Tag filtering.Better filter zones by tag |
|
As this has a lot of upvotes and enables ExternalDNS to be used on Tectonic ❤️ I would like get this in. I'm not in favour of this implementation howver as it's a bit too magical and enforces users to use the trailing dot notation if they indeed want to keep matching by dns name. How about we add another flag called What do you think @dileepfrog @jrnt30 @sean-krail @redbaron ? |
linki
added
the
help wanted
|
If you can specify that flag multiple times to allow multiple zones to be managed, I am fine. Still prefer tagging approach, but since I am not supporting my preference with concrete code in a form of PR, it is not relevant :) |
|
I also think it would be nice to be able to specify a list of zoneIDs, but most commonly would use one. FWIW; the reason Tectonic does this is to enable components within the cluster to use the private network when communicating with the control plane, so theres two hosted zones created so that within the cluster. It's effectively split horizon DNS. Everything from inside the network can use the private hosted zone which uses the private IPs for everything. This is only for if your exposing your cluster publicly though. If it's private, then theres only the private hosted zone. Also if this is blocking you, I believe the tectonic installer supports not creating a private hosted zone if you don't want one. |
|
@jose5918 Fixed the conflicts in jose5918#1 |
Merge with master
k8s-ci-robot
added
the
size/S
|
@dileepfrog I believe this PR is now obsolete since we added a separate flag for filtering by |
|
Closing this because of #322 (comment) @dileepfrog feel free to reopen this PR if I'm wrong. |
* lint: integrate impi * install impi in a tmp folder * put install into func and install master
The Tectonic installer, for example, will always create a private zone with the same DNS name as the public one (a shortcoming of Tectonic to be sure), which breaks external-dns. Explicitly being able to specify the public zone would address this issue.