Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secretConfiguration.subPath to mount specific files from secret #3227

Merged
merged 2 commits into from Dec 12, 2022
Merged

Add secretConfiguration.subPath to mount specific files from secret #3227

merged 2 commits into from Dec 12, 2022

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Dec 9, 2022 •
edited

Description

Add secretConfiguration.subPath to mount specific files from the new secret configuration

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2022
stevehipwell
stevehipwell suggested changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jkroepke I've added some suggested changes.

charts/external-dns/README.md Outdated Show resolved Hide resolved
charts/external-dns/values.yaml Outdated Show resolved Hide resolved
@jkroepke @stevehipwell
Apply suggestions from code review
26379de 
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
@jkroepke jkroepke requested review from stevehipwell and removed request for szuecs December 9, 2022 22:29
@stevehipwell
Copy link
Contributor

Thanks @jkroepke.

/lgtm
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@stevehipwell
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkroepke, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit c887237 into kubernetes-sigs:master Dec 12, 2022
@jkroepke jkroepke deleted the sub-path branch February 6, 2023 22:39
@renovate renovate bot mentioned this pull request Sep 7, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehipwell stevehipwell Awaiting requested review from stevehipwell

Assignees

@stevehipwell stevehipwell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkroepke @stevehipwell @k8s-ci-robot