Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create an alias when record in a zone another than the target #3338

Merged
merged 1 commit into from Jun 26, 2023

Conversation

epollia
Copy link
Contributor

@epollia epollia commented Jan 24, 2023

Description

DNS cannot work with cname whose target is another domain.
Example (This cname does not work.):
ads.localhost in google.com CNAME

But PowerDNS can create ALIAS
This PR changes the pdns provider to create aliases for such entries. This is required when k8s uses alb/nld on AWS etc.

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 24, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 24, 2023
@epollia epollia changed the title create an alias when creord in a zone another than the target create an alias when record in a zone another than the target Jan 24, 2023
@tommy31
Copy link
Contributor

tommy31 commented Jan 30, 2023

Hey,
This issue is related to #3253. Same enhancement is required for gandi.
Maybe we should find a solution at the core level of external-dns and not in each provider as this seems comons to use ALIAS on a lot a providers.
Regards

@ngnix
Copy link

ngnix commented Mar 31, 2023

Hey guys, do you have any update?

@reyvonger
Copy link

any update?

@szuecs
Copy link
Contributor

szuecs commented Jun 26, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: epollia, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit f26fa4b into kubernetes-sigs:master Jun 26, 2023
3 checks passed
@tmaroschik
Copy link
Contributor

@tommy31 and @szuecs This change is intentionally good, but it affects all non-apex records in pdns aswell and creates aliases for records that should be CNAME. So it introduces a bug.

See: #3970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants