Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow annotation target override on gateway #3452

Merged
merged 5 commits into from Sep 15, 2023
Merged

Allow annotation target override on gateway #3452

merged 5 commits into from Sep 15, 2023

Conversation

BadLiveware
Copy link
Contributor

@BadLiveware BadLiveware commented Mar 5, 2023 •
edited

Description
This allows the external-dns.alpha.kubernetes.io/target annotation to work for gateway api resources

Fixes #ISSUE

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 5, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2023
@BadLiveware BadLiveware force-pushed the feature/allow-target-annotation-gateway branch from da02bf5 to 3e2b3dc Compare March 5, 2023 17:03
@BadLiveware
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 16, 2023
@johngmyers
Copy link
Contributor

/lgtm
/assign njuettner

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2023
@BadLiveware BadLiveware mentioned this pull request Jul 3, 2023
Closed
@johngmyers
Copy link
Contributor

@BadLiveware could you please update doc/annotations/annotations.md? Please add a footnote that the annotation should be on the Gateway.

@BadLiveware BadLiveware force-pushed the feature/allow-target-annotation-gateway branch from 3e2b3dc to bd568e9 Compare July 5, 2023 07:55
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
@BadLiveware
Copy link
Contributor Author

@BadLiveware could you please update doc/annotations/annotations.md? Please add a footnote that the annotation should be on the Gateway.

Rebased and updated

johngmyers
johngmyers suggested changes Jul 6, 2023
View reviewed changes
source/gateway.go Outdated Show resolved Hide resolved
source/gateway_httproute_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2023
@johngmyers
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 7, 2023
@BadLiveware
Copy link
Contributor Author

@johngmyers is this waiting on a review by @njuettner ?

@johngmyers
Copy link
Contributor

@BadLiveware yes. The approvers aren't terribly responsive at the best of times and it's European vacation season.

@BadLiveware
Copy link
Contributor Author

BadLiveware commented Jul 25, 2023 via email

@johngmyers
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@johngmyers
Copy link
Contributor

/test pull-external-dns-lint
/test pull-external-dns-unit-test

@k8s-ci-robot k8s-ci-robot merged commit 65db0c7 into kubernetes-sigs:master Sep 15, 2023
15 of 16 checks passed
@johngmyers johngmyers mentioned this pull request Sep 17, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers requested changes

@njuettner njuettner Awaiting requested review from njuettner

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@johngmyers johngmyers

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BadLiveware @johngmyers @k8s-ci-robot @njuettner