[TXT Registry] Disable generation of old style txt records when encryption is enabled #3735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue, current behaviour is unable to work with AWS which requires the
Delete
change request to be called with the exact same record set that is currently present in Route53. This is currently not happening due to:labelsMap
when iterating through the TXT labels.Records()
will delete the nonce from the labels.generateTXTRecord
from within ApplyChanges will have to regenerate the nonce once again, ending up with an entirely different target.This change disables the generation of the old style txt records and old to new migrations when encryption is enabled.
Fixes #3668
Depends on #3724
Checklist