fix: regression on scaleway provider in 0.14.0

[M0NsTeRRR]

fix issue #4032 and regression of PR #4002

[k8s-ci-robot]

Hi @M0NsTeRRR. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mloiseleur]

/ok-to-test
/lgtm

[mloiseleur]

/lgtm cancel

[mloiseleur]

In fact, in order to avoid encounter this regression again, would you please add a test case ?

[M0NsTeRRR]

Yes will look into in :)

[szuecs]

here you overwrite the error and it's not clear why we don't care about the error.

[M0NsTeRRR]

I've reused the same logic from the original PR that has been reviewed but we can change this of course. I can add a log when the file can't be loaded and when the profile was not loaded too if that's okay for you.

[szuecs]

yes please, I added an example how to make it better. I hope it helps.

[M0NsTeRRR]

I keep this thread as it's the one that make most sense from the original idea.
I've added warning in logging because if someone try to use config file and the file contains error he will not be warned about that and can't understand the issue, that's why I think logs are better in the end.
If you don't like the submitted code, feel free to change it as I've don't a lot of knowledge in Go and don't want to waste your time in reviewing and make it hard. Was doing it to help a bit if I can 🙂.

Regards,

[mloiseleur]

/lgtm

[mloiseleur]

/lgtm

[szuecs]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[didlawowo]

i have similar issue with external dns over gke a last version with bitnami chart.

msg="Instantiating new Kubernetes client" │
│ time="2024-01-03T00:27:39Z" level=info msg="Using inCluster-config based on serviceaccount-token" │
│ time="2024-01-03T00:27:39Z" level=info msg="Created Kubernetes client https://10.1.0.1:443" │
│ panic: scaleway-sdk-go: cannot read config file /.config/scw/config.yaml: no such file or directory │
│ │
│ goroutine 1 [running]: │
│ github.com/scaleway/scaleway-sdk-go/scw.MustLoadConfig() │
│ /bitnami/blacksmith-sandox/external-dns-0.14.0/src/github.com/kubernetes-incubator/external-dns/vendor/github.com/scaleway/scaleway-sdk-go/scw/config.go:18 │
│ sigs.k8s.io/external-dns/provider/scaleway.NewScalewayProvider({0x80f3e749c34a40d9?, 0x9e6c3a0b94cb3235?}, {{0xc0001401e0, 0x2, 0x2}, {0x0, 0x0, 0x0}, 0x0, 0x0 │
│ /bitnami/blacksmith-sandox/external-dns-0.14.0/src/github.com/kubernetes-incubator/external-dns/provider/scaleway/scaleway.go:68 +0xd4 │
│ main.main() │
│ /bitnami/blacksmith-sandox/external-dns-0.14.0/src/github.com/kubernetes-incubator/external-dns/main.go:383 +0x30ae

[didlawowo]

value in secret are correct: Environment: │
│ SCW_ACCESS_KEY: <set to the key 'scw_access_key' in secret 'external-dns'> Optional: false │
│ SCW_SECRET_KEY: <set to the key 'scw_secret_key' in secret 'external-dns'> Optional: false │
│

[M0NsTeRRR]

i have similar issue with external dns over gke a last version with bitnami chart.

msg="Instantiating new Kubernetes client" │
│ time="2024-01-03T00:27:39Z" level=info msg="Using inCluster-config based on serviceaccount-token" │
│ time="2024-01-03T00:27:39Z" level=info msg="Created Kubernetes client https://10.1.0.1:443" │
│ panic: scaleway-sdk-go: cannot read config file /.config/scw/config.yaml: no such file or directory │
│ │
│ goroutine 1 [running]: │
│ github.com/scaleway/scaleway-sdk-go/scw.MustLoadConfig() │
│ /bitnami/blacksmith-sandox/external-dns-0.14.0/src/github.com/kubernetes-incubator/external-dns/vendor/github.com/scaleway/scaleway-sdk-go/scw/config.go:18 │
│ sigs.k8s.io/external-dns/provider/scaleway.NewScalewayProvider({0x80f3e749c34a40d9?, 0x9e6c3a0b94cb3235?}, {{0xc0001401e0, 0x2, 0x2}, {0x0, 0x0, 0x0}, 0x0, 0x0 │
│ /bitnami/blacksmith-sandox/external-dns-0.14.0/src/github.com/kubernetes-incubator/external-dns/provider/scaleway/scaleway.go:68 +0xd4 │
│ main.main() │
│ /bitnami/blacksmith-sandox/external-dns-0.14.0/src/github.com/kubernetes-incubator/external-dns/main.go:383 +0x30ae

You have to stick to 0.13.6 until they release a new version that embed this fix.