add a basic integration test for service/google #63
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
should this bash script also create a docker container to run alongside the executed commands ? |
linki
added
the
do-not-merge
|
My current goal is to run this on travis. Would also mean that I have to configure credentials there and have proper cleanup. Probably have to clarify with some people. Whatever is needed is in-scope. |
linki
changed the title
linki
changed the title
linki
added
work-in-progress
and removed
do-not-merge
|
it now uses a built image of external-dns. Also grabs credentials from your local machine. @ideahitme you want to give it a shot? Putting that on our CI needs a couple more steps though. |
| do | ||
| sleep 5 | ||
|
|
||
| DNS_TARGET=$(dig +short nginx-ingress.external-dns-test.gcp.zalan.do.) |
There was a problem hiding this comment.
This could return more than one ip and then your == will fail.
I guess it does not happen, now but maybe in the future.
Maybe add a TODO for it.
| do | ||
| sleep 5 | ||
|
|
||
| DNS_TARGET=$(dig +short nginx.external-dns-test.gcp.zalan.do.) |
| do | ||
| sleep 5 | ||
|
|
||
| DNS_TARGET=$(dig @ns-cloud-b1.googledomains.com. +short nginx.external-dns-test.gcp.zalan.do.) |
|
Thnaks for your review @szuecs. |
|
Closing to reduce work-in-progress. Will follow up at some point. A set of integration tests per DNS provider is fairly important, imo. |
- remove access to internals of KrewPaths and provide methods - rename KrewPaths to Paths (tentative) - make Paths testable + add tests - MustGetKrewPaths: add test for home dir detection This PR paves the way to; - add environment-variable overrides for krew base path and have it testable - refactor common filepath.Join()s that happen around returned paths so they are not repeated in the plugin lifecycle logic.
This is a bash file doing a simple integration test with a Service and Google DNS.