Resolving last bits of feedback from Lior's PR

kubernetes-sigs · Oct 9, 2023 · 8951d25 · 8951d25
1 parent efddbff
commit 8951d25
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/apis/v1beta1/gatewayclass_types.go b/apis/v1beta1/gatewayclass_types.go
@@ -245,10 +245,9 @@ type GatewayClassStatus struct {
 	// +kubebuilder:default={{type: "Accepted", status: "Unknown", message: "Waiting for controller", reason: "Pending", lastTransitionTime: "1970-01-01T00:00:00Z"}}
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 
-	// TODO(LiorLieberman) explore adding CEL validation to ensure the list is sorted.
 	// SupportedFeatures is the set of features the GatewayClass support.
-	// It should be sorted in ascending alphabetical order.
-	//+optional
+	// It MUST be sorted in ascending alphabetical order.
+	// +optional
 	// +listType=set
 	// <gateway:experimental>
 	// +kubebuilder:validation:MaxItems=64