Skip to content

Commit

Permalink
Fix further PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: Nick Young <nick@isovalent.com>
  • Loading branch information
youngnick committed Oct 9, 2023
1 parent 0ae6b52 commit 8e68d61
Show file tree
Hide file tree
Showing 3 changed files with 102 additions and 93 deletions.
15 changes: 10 additions & 5 deletions apis/v1beta1/gateway_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,18 @@ type GatewaySpec struct {
// Practically, this means that each listener in a set MUST have a unique
// combination of Port, Protocol, and, if supported by the protocol, Hostname.
//
// Some combinations of port, protocol, and TLS settings are are considered
// Core support and MUST be supported by implementations if they support the
// associated Route type:
// Some combinations of port, protocol, and TLS settings are considered
// Core support and MUST be supported by implementations based on their
// targeted conformance profile:
//
// HTTP Profile
//
// 1. HTTPRoute, Port: 80, Protocol: HTTP
// 2. HTTPRoute, Port: 443, Protocol: HTTPS, TLS Mode: Terminate, TLS keypair provided
// 3. TLSRoute, Port: 443, Protocol: TLS, TLS Mode: Passthrough
//
// TLS Profile
//
// 1. TLSRoute, Port: 443, Protocol: TLS, TLS Mode: Passthrough
//
// "Distinct" Listeners have the following property:
//
Expand Down Expand Up @@ -138,7 +143,7 @@ type GatewaySpec struct {
// Implementations MAY choose to accept a Gateway with Conflicted
// Listeners if they accept a partial Listener set that contains no
// Conflicted Listeners. They MUST set a "ListenersNotValid" condition
// the Gateway Status when the Gateway contains Conflicted Listeners
// on the Gateway Status when the Gateway contains Conflicted Listeners
// whether or not they accept the Gateway. That Condition SHOULD clearly
// indicate in the Message which Listeners are conflicted.
//
Expand Down
90 changes: 46 additions & 44 deletions config/crd/experimental/gateway.networking.k8s.io_gateways.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8e68d61

Please sign in to comment.