Add Analysis section to describe views for relevant resources

kubernetes-sigs · May 5, 2024 · b4a17ba · b4a17ba
1 parent 31498de
commit b4a17ba
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/gwctl/pkg/printer/backends.go b/gwctl/pkg/printer/backends.go
@@ -170,6 +170,11 @@ func (bp *BackendsPrinter) PrintDescribeView(resourceModel *resourcediscovery.Re
 			pairs = append(pairs, &DescriberKV{Key: "ReferenceGrants", Value: names})
 		}
 
+		// Analysis
+		if len(backendNode.Errors) != 0 {
+			pairs = append(pairs, &DescriberKV{Key: "Analysis", Value: convertErrorsToString(backendNode.Errors)})
+		}
+
 		// Events
 		pairs = append(pairs, &DescriberKV{Key: "Events", Value: convertEventsSliceToTable(backendNode.Events, bp.Clock)})
 

diff --git a/gwctl/pkg/printer/common.go b/gwctl/pkg/printer/common.go
@@ -171,6 +171,14 @@ func convertPolicyRefsToTable(policyRefs []common.ObjRef) *Table {
 	return table
 }
 
+func convertErrorsToString(errors []error) []string {
+	var result []string
+	for _, err := range errors {
+		result = append(result, err.Error())
+	}
+	return result
+}
+
 type NodeResource interface {
 	ClientObject() client.Object
 }

diff --git a/gwctl/pkg/printer/gateways.go b/gwctl/pkg/printer/gateways.go
@@ -135,6 +135,11 @@ func (gp *GatewaysPrinter) PrintDescribeView(resourceModel *resourcediscovery.Re
 			pairs = append(pairs, &DescriberKV{Key: "EffectivePolicies", Value: gatewayNode.EffectivePolicies})
 		}
 
+		// Analysis
+		if len(gatewayNode.Errors) != 0 {
+			pairs = append(pairs, &DescriberKV{Key: "Analysis", Value: convertErrorsToString(gatewayNode.Errors)})
+		}
+
 		// Events
 		pairs = append(pairs, &DescriberKV{Key: "Events", Value: convertEventsSliceToTable(gatewayNode.Events, gp.Clock)})