Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEP: Add support for Route inclusion and delegation #1058

Closed
Jeff-Apple opened this issue Mar 22, 2022 · 7 comments
Closed

GEP: Add support for Route inclusion and delegation #1058

Jeff-Apple opened this issue Mar 22, 2022 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@Jeff-Apple
Copy link
Contributor

Jeff-Apple commented Mar 22, 2022

What would you like to be added:
Add support for a 2-tier hierarchy of route configuration to allow partial delegation of route settings and, provide more flexibility in how route configurations are organized and managed.

The formal GEP document will be based on the following document but with some changes based on the feedback and discussions that have taken place since it was last modified: K8s Gateway API - Route inclusion and delegation

Why this is needed:

  1. The current model for delegation in Gateway API, has only one point where gateway owners can delegate some of the route configuration; where Routes attach to Listeners. This is basically an all or nothing model with very little flexibility.

  2. Some scenarios need multiple RouteRules to have a subset of configuration settings that are the same in all of them (e.g., a specific RouteFilter config). The RouteRules might be in the same Route or many Routes. The only way to currently do that is to administratively add those settings to each RouteRule. This can result in much larger Route configurations and, frequently, configuration drift over time.

Additional Information:
This issue is for tracking the progress of the PR containing the formal GEP document.

Link to PR: #1085

@Jeff-Apple Jeff-Apple added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 22, 2022
@Jeff-Apple Jeff-Apple changed the title GEP: Add support for Route inclusion and delegation GEP-1058: Add support for Route inclusion and delegation Mar 22, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2022
@robscott
Copy link
Member

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 14, 2022
@robscott robscott changed the title GEP-1058: Add support for Route inclusion and delegation GEP: Add support for Route inclusion and delegation Aug 2, 2022
@shaneutt shaneutt closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2023
@shaneutt shaneutt reopened this Mar 8, 2023
@shaneutt
Copy link
Member

shaneutt commented Mar 8, 2023

Ultimately #1085 was auto-closed due to inactivity, so it would appear that for the moment we don't have anyone actively championing this effort and moving it forward. For now we'll consider it closed, but if anyone is interested in pushing for it please do feel free to ping here and we can re-open it any time.

@shaneutt shaneutt closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2023
@EItanya
Copy link
Contributor

EItanya commented Nov 30, 2023

I am interested in this effort. However, I am interested in hearing other people's summary of the current state. It appears that the design doc and GEP were both very close to finished, but never agreed on. Can someone with more context potentially enumerate the existing issues with the design. It seems to be that the biggest issues come down to the re-use of the HTTPRoute as both a child and a parent, and the complexity inherent in that choice.

@youngnick
Copy link
Contributor

Yes, the current state is that this is basically abandoned, because it's very difficult to define how the inclusion should work while still using HTTPRoute as the object.

I should also note that past experience says this will be a lot of work, so I think that interested folks should look at restarting with a fresh Github Discussion. But I think it's fair to say that this will require some pushing, as there are a number of other features currently higher on the priority list.

@EItanya
Copy link
Contributor

EItanya commented Dec 1, 2023

That's fair, is there a list of current prioritized items?

@shaneutt
Copy link
Member

shaneutt commented Dec 1, 2023

I don't recall us leaving this with any sort of playbook about what to do next 🤔

My perspective: while I think there's plenty of prior art to consult here, I think the next step for you as someone interested would be to propose a "What" and "Why" in something like a GitHub discussion (and also put it on the meeting agendas to discuss periodically), basically as a new effort that references the old one: let's try to determine with strong clarity what we want to do and why we want to do it, with no "how" we do it yet. I personally would particularly want to see more user stories that help to show the value to Gateway API end-users. Through that discussion process we should gather at least one (if not multiple) other implementers who need this and are in alignment on the what and why. If we can establish that, this might be good grounds for a re-open, or maybe more appropriately a new GEP inspired by the original work.

Does that make sense, and is that helpful to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Development

No branches or pull requests

7 participants