Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance test to exercise adding multiple listeners #1607

Closed
dprotaso opened this issue Dec 16, 2022 · 5 comments · Fixed by #1827
Closed

Conformance test to exercise adding multiple listeners #1607

dprotaso opened this issue Dec 16, 2022 · 5 comments · Fixed by #1827
Labels
area/conformance good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@dprotaso
Copy link
Contributor

From: #1586 (comment)_

It sounds like there's a gap in the conformance suite as we it doesn't exercise adding new listeners to a gateway.

The language in the spec seems to indicate you should be able to update Gateways and add/remove listeners.

@shaneutt shaneutt added area/conformance priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 16, 2022
@shaneutt shaneutt added this to the v0.6.1 milestone Dec 16, 2022
@shaneutt shaneutt added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 16, 2022
@sunjayBhatia
Copy link
Member

Should capture the expectation that listeners with different ports, hostnames, protocols, etc. will be tested

@robscott
Copy link
Member

robscott commented Jan 6, 2023

Hey @nilabjasarkar123, your comment does not add to the discussion here. This issue is intended to track adding a conformance test for a specific topic, your ChatGPT generated response is attempting to answer a question that was not asked.

@shaneutt shaneutt modified the milestones: v0.6.1, v0.6.2 Jan 31, 2023
@shaneutt shaneutt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 21, 2023
@shaneutt shaneutt modified the milestones: v0.6.2, v0.7.0 Mar 14, 2023
@shaneutt
Copy link
Member

/assign mmamczur

@k8s-ci-robot
Copy link
Contributor

@shaneutt: GitHub didn't allow me to assign the following users: mmamczur.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign mmamczur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Contributor Author

FYI - the merge test only assumes port 80 & 443 can be added/removed

There's a follow up issue here - #1842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants