Adding back ReferencePolicy with a note that it will be removed in v0.6.0 #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
approved
shaneutt
approved these changes
Jun 13, 2022
| // Additional Reference Policies can be used to add to the set of trusted | ||
| // Additional Reference Grants can be used to add to the set of trusted |
| // +genclient | ||
| // +kubebuilder:object:root=true | ||
| // +kubebuilder:resource:categories=gateway-api,shortName=refpol | ||
| // +kubebuilder:deprecatedversion:warning="ReferencePolicy has been renamed to ReferenceGrant. ReferencePolicy will be removed in v0.6.0 in favor of the identical ReferenceGrant resource." |
There was a problem hiding this comment.
Looks good. Should we add an issue that references this line to v0.6.0 so that we get a upfront reminder?
13 tasks
nathancoleman
approved these changes
Jun 14, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nathancoleman, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This addresses #1201 since at least some implementations will want to support both ReferencePolicy and ReferenceGrant concurrently.
For reference, this is what the deprecation warning looks like:
Which issue(s) this PR fixes:
Fixes #1201
Does this PR introduce a user-facing change?: