Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance: fix Listener ConditionReason #1305

Merged

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Aug 9, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:
In the "GatewaySecretInvalidReferenceGrant" and "GatewaySecretMissingReferenceGrant" conformance tests for gateways, the expected condition has been changed from InvalidCertificateRef to RefNotPermitted.

Which issue(s) this PR fixes:

Fixes #1297

Does this PR introduce a user-facing change?:

To be conformant with the API, if there is no ReferenceGrant that grants a listener to reference a secret in another namespace, the ListenerConditionReason for the condition ResolvedRefs must be set to RefNotPermitted instead of InvalidCertificateRef.

In the "GatewaySecretInvalidReferenceGrant" and "GatewaySecretMissingReferenceGrant" conformance tests for gateways, the expected condition has been
changed from InvalidCertificateRef to RefNotPermitted.

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @mlavacca!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mlavacca. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2022
@shaneutt shaneutt self-assigned this Aug 9, 2022
@shaneutt shaneutt added this to the v0.6.0 milestone Aug 9, 2022
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for identifying this problem and resolving it 🖖

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2bd7302 into kubernetes-sigs:main Aug 9, 2022
sunjayBhatia added a commit to sunjayBhatia/contour that referenced this pull request Aug 10, 2022
…eason RefNotPermitted

See kubernetes-sigs/gateway-api#1305

Fixes conformance test failures on main

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
k8s-ci-robot added a commit that referenced this pull request Aug 22, 2022
sunjayBhatia added a commit to projectcontour/contour that referenced this pull request Aug 25, 2022
…eason RefNotPermitted (#4664)

See kubernetes-sigs/gateway-api#1305 and kubernetes-sigs/gateway-api#1334

Fixes conformance test failures on main

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conformance: gateway tests expecting wrong ListenerConditionReason
3 participants