Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifying HTTPRoute exact match behavior #2055

Merged
merged 1 commit into from May 23, 2023
Merged

Clarifying HTTPRoute exact match behavior #2055

merged 1 commit into from May 23, 2023

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind cleanup
/area conformance

What this PR does / why we need it:
This clarifies that exact path matches in HTTPRoute are truly exact. Both trailing slashes and capitalization are meaningful. This matches the consensus on #1953 and from our community meeting today. It also largely matches what our conformance tests already covered, this just slightly expands that coverage.

Which issue(s) this PR fixes:
Fixes #1953

Does this PR introduce a user-facing change?:

HTTPRoute: Clarified that exact path matches are truly exact, both trailing slashes and capitalization are meaningful.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@robscott robscott added this to the v0.7.1 milestone May 23, 2023
@robscott
Copy link
Member Author

Whenever this gets in, it also needs to go to v0.7.1.

/cherry-pick release-0.7

@k8s-infra-cherrypick-robot
Copy link

@robscott: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

In response to this:

Whenever this gets in, it also needs to go to v0.7.1.

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shaneutt
shaneutt approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/cc @michaelbeaumont @sunjayBhatia @arkodg @Xunzhuo

@shaneutt shaneutt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelbeaumont, mlavacca, robscott, shaneutt, sunjayBhatia, Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt
Copy link
Member

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4738c6c into kubernetes-sigs:main May 23, 2023
9 checks passed
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 23, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@robscott: new pull request created: #2056

In response to this:

Whenever this gets in, it also needs to go to v0.7.1.

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott robscott mentioned this pull request May 24, 2023
Merged
@zhaohuabing zhaohuabing mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@shaneutt shaneutt shaneutt approved these changes

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@mlavacca mlavacca mlavacca approved these changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@bowei bowei Awaiting requested review from bowei

@arkodg arkodg Awaiting requested review from arkodg

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7.1
Development

Successfully merging this pull request may close these issues.

Clarify whether trailing slash is meaningful for exact path match
8 participants
@robscott @k8s-infra-cherrypick-robot @k8s-ci-robot @shaneutt @michaelbeaumont @sunjayBhatia @mlavacca @Xunzhuo