rm webhook resources from installation yaml #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
Add a seperate `webhook-install.yaml` file instead which contains only webhook resources which someone may choose to optionally install Fixes: kubernetes-sigs#2400 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
force-pushed
the
rm-admission-server-install
branch
from
18102b6
to
67dd2fb
Compare
k8s-ci-robot
added
size/S
|
Thanks @arkodg! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arkodg, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
bartsmykla
added a commit
to bartsmykla/kuma-website
that referenced
this pull request
Apr 15, 2024
- Gateway API doesn't need to be installed in Experimental Channel anymore, as we are not supporting any of experimental features yet, so I changed the instruction to reflect that. - Admission Webhook doesn't come with CRDs anymore, so we can safely stop mentioning it (re. kubernetes-sigs/gateway-api#2401) Signed-off-by: Bart Smykla <bartek@smykla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fixes # #2400
Does this PR introduce a user-facing change?: