Documenting Listener Isolation in Gateway Spec #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
Actually, no, it's fine, I'll LGTM this. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
sunjayBhatia
added a commit
to sunjayBhatia/contour
that referenced
this pull request
Feb 7, 2024
Requests should be "isolated" to the most specific Listener and it's attached routes. This means our existing logic on finding intersecting route and Listener hostnames needs an update to factor in the other Listeners on a Gateway that the route in question may not actually be attached to. Fix for conformance test: kubernetes-sigs/gateway-api#2669 kubernetes-sigs/gateway-api#2465 for spec Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
added a commit
to sunjayBhatia/contour
that referenced
this pull request
May 3, 2024
Requests should be "isolated" to the most specific Listener and it's attached routes. This means our existing logic on finding intersecting route and Listener hostnames needs an update to factor in the other Listeners on a Gateway that the route in question may not actually be attached to. Fix for conformance test: kubernetes-sigs/gateway-api#2669 kubernetes-sigs/gateway-api#2465 for spec Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
This PR is a follow up to #2416. It introduces a new concept called "Listener Isolation" to describe the recommendation that at most one Listener matches a request, and only Routes attached to that Listener are used for routing.
Originally I'd planned to consider this an "Extended" feature (see #2416 (comment)) but generally the idea of "Extended" and "Core" is per-field, not really a description of behavior. So instead I'm using "SHOULD" which per RFC-2119 is a recommendation and not a requirement. This does add the requirement that implementations that do not support Listener Isolation must document that.
Which issue(s) this PR fixes:
Related to #2416 but leaving open until conformance tests are present.
Does this PR introduce a user-facing change?: