Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add h2c server to echo-basic #2472

Merged
merged 4 commits into from
Oct 12, 2023
Merged

add h2c server to echo-basic #2472

merged 4 commits into from
Oct 12, 2023

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Oct 11, 2023 •
edited

Pulls the image changes from: #2456

/kind test

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 11, 2023
@dprotaso dprotaso marked this pull request as ready for review October 11, 2023 21:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2023
@dprotaso dprotaso changed the title add h2c endpoint to echo server add h2c endpoint to echo-basic Oct 11, 2023
robscott
robscott reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dprotaso!

conformance/echo-basic/echo-basic.go Outdated Show resolved Hide resolved
conformance/echo-basic/echo-basic.go Outdated Show resolved Hide resolved
@dprotaso
Copy link
Contributor Author

dprotaso commented Oct 12, 2023 •
edited

Tested with the following commands

$ curl  -vvv --http2-prior-knowledge localhost:3001
succeeds

$ curl  -vvv --http2 localhost:3001 # does the HTTP - Upgrade:h2c Flow
succeeds

$ curl  -vvv localhost:3001
fails (as expected)

@dprotaso dprotaso changed the title add h2c endpoint to echo-basic add h2c server to echo-basic Oct 12, 2023
@robscott
Copy link
Member

Thanks @dprotaso!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@robscott
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3765482 into kubernetes-sigs:main Oct 12, 2023
8 checks passed
@dprotaso dprotaso deleted the h2c-echo-server branch October 12, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@arkodg arkodg Awaiting requested review from arkodg

@bowei bowei Awaiting requested review from bowei

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dprotaso @k8s-ci-robot @robscott