Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop experimental banner for backend-protocol selection #3120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop experimental banner for backend-protocol selection #3120

wants to merge 2 commits into from

Conversation

dprotaso
Copy link
Contributor

What type of PR is this?
/kind documentation
/gep

What this PR does / why we need it:
Docs changes for backend protocol selection for Gateway Release v1.2

Which issue(s) this PR fixes:

Part of #1911

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2024
@dprotaso dprotaso mentioned this pull request May 30, 2024
Merged
@dprotaso
Copy link
Contributor Author

/hold

This should be merged after 1.2 is cut - See: #3108 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2024
@dprotaso dprotaso force-pushed the promote-backend-protocol-docs branch from 6620918 to bc5fcad Compare July 4, 2024 00:47
@dprotaso dprotaso force-pushed the promote-backend-protocol-docs branch from bc5fcad to d68bde6 Compare July 4, 2024 00:47
@youngnick
Copy link
Contributor

LGTM, thanks @dprotaso

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngnick youngnick youngnick left review comments

@robscott robscott Awaiting requested review from robscott

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dprotaso @youngnick @k8s-ci-robot