Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposal for GEPs #684

Merged
merged 3 commits into from Jul 1, 2021
Merged

Add proposal for GEPs #684

merged 3 commits into from Jul 1, 2021

Conversation

bowei
Copy link
Contributor

@bowei bowei commented May 25, 2021 •
edited

Add proposal for GEP process

Fixes #696

/kind feature
/kind design

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/design Categorizes issue or PR as related to design. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2021
robscott
robscott reviewed May 25, 2021
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I think this is a great starting point. I think it would be ideal to move some of this content into a new GEP directory as an initial template. Beyond KEPs, I think both Cluster API and Helm provide good examples of this format:

https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/proposals/YYYYMMDD-template.md
https://github.com/helm/community/blob/main/hips/hip-0001.md

site-src/contributing/gep.md Show resolved Hide resolved
site-src/contributing/gep.md Show resolved Hide resolved
@youngnick
Copy link
Contributor

I'm a very strong +1 on this, I think that we are making some decisions for v1alpha2 that, no matter what the decision ends up being, will really need context stored somewhere for the future.

@bowei bowei force-pushed the gep branch 2 times, most recently from 762cef1 to 866827e Compare June 18, 2021 17:55
@bowei
Copy link
Contributor Author

bowei commented Jun 18, 2021

Hi -- updated the language in the GEP -- please take a look!

@youngnick
Copy link
Contributor

Changes lgtm but I'll leave it for @robscott or @hbagdi to give the final tick.

hbagdi
hbagdi reviewed Jun 22, 2021
View reviewed changes
site-src/contributing/gep.md Show resolved Hide resolved
site-src/geps/gep-684.md Outdated Show resolved Hide resolved
@bowei bowei force-pushed the gep branch 2 times, most recently from 8af71d7 to d4e67c3 Compare June 25, 2021 17:39
robscott
robscott reviewed Jun 25, 2021
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a few nits.

site-src/contributing/enhancement-requests.md Outdated Show resolved Hide resolved
site-src/contributing/enhancement-requests.md Outdated
Inspired by [Kubernetes enhancements](https://github.com/kubernetes/enhancements), service-api's
provides a process for introducing new functionality or considerable changes to the project. The
enhancement process will evolve over time as the project matures.
Inspired by [Kubernetes enhancements][enhance], service-api's provides a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep on finding places I missed in the rename:

Suggested change
Inspired by [Kubernetes enhancements][enhance], service-api's provides a
Inspired by [Kubernetes enhancements][enhance], Gateway API provides a

site-src/contributing/enhancement-requests.md Outdated Show resolved Hide resolved
@hbagdi
Copy link
Contributor

hbagdi commented Jun 29, 2021

LGTM from content perspective.

@bowei @robscott
Update site-src/v1alpha2/contributing/enhancement-requests.md
44628df 
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 1, 2021
@robscott
Copy link
Member

robscott commented Jul 1, 2021

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7de5e63 into kubernetes-sigs:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@hbagdi hbagdi hbagdi left review comments

@thockin thockin Awaiting requested review from thockin

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GEP process
5 participants
@bowei @k8s-ci-robot @youngnick @hbagdi @robscott