Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving v1alpha2 to the gateway.networking.k8s.io API Group #707

Merged
merged 1 commit into from Jul 12, 2021
Merged

Moving v1alpha2 to the gateway.networking.k8s.io API Group #707

merged 1 commit into from Jul 12, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Jul 8, 2021

What type of PR is this?
/kind cleanup
/kind api-change

What this PR does / why we need it:
Fixes #690

Does this PR introduce a user-facing change?:

The API Group has changed from networking.x-k8s.io to gateway.networking.k8s.io for v1alpha2 and beyond.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2021
@robscott robscott force-pushed the apigroup branch 3 times, most recently from 0fcf8e5 to b9769e1 Compare July 8, 2021 18:11
@hbagdi
Copy link
Contributor

hbagdi commented Jul 8, 2021

Great work!
Can you please update admission_webhook.yaml to include the new group? With the current patch, admission webhook won't be triggered.

I can't think of any other thing that might stop working but I expect some amount of whack-a-mole with this one.

@robscott
Copy link
Member Author

robscott commented Jul 9, 2021

Thanks for catching that @hbagdi! Should be updated now.

@hbagdi
Copy link
Contributor

hbagdi commented Jul 9, 2021

@robscott There is a merge conflict because the other PR got merged in.
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 9, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 9, 2021
@robscott
Copy link
Member Author

robscott commented Jul 9, 2021

@hbagdi thanks for the reviews! Just rebased this after the latest conflict.

hbagdi
hbagdi reviewed Jul 12, 2021
View reviewed changes
hack/update-codegen.sh
--input-dirs "${FQ_APIS}" \
--output-package "${FQ_APIS}" \
${COMMON_FLAGS}
# TODO(robscott): Change this once v1alpha2 has received formal API approval.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robscott Can we please create a Github issue to track this and possibly reference this here in a follow up PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks for catching that! #716

@hbagdi
Copy link
Contributor

hbagdi commented Jul 12, 2021

/lgtm

@robscott Merging this in but please create an issue to track formal API approval.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 70bc94a into kubernetes-sigs:master Jul 12, 2021
liggitt
liggitt reviewed Aug 5, 2021
View reviewed changes
config/crd/bases/gateway.networking.k8s.io_backendpolicies.yaml
kind: CustomResourceDefinition
metadata:
annotations:
api-approved.kubernetes.io: unapproved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an issue tracking getting this approved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#716 + kubernetes/enhancements#2830

@aojea aojea mentioned this pull request Aug 11, 2021
Merged
@robscott robscott deleted the apigroup branch January 8, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@hbagdi hbagdi hbagdi left review comments

@bowei bowei Awaiting requested review from bowei

@danehans danehans Awaiting requested review from danehans

Assignees

@hbagdi hbagdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change API group from x-k8s.io to k8s.io
4 participants
@robscott @k8s-ci-robot @hbagdi @liggitt