Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APISIX implementation #843

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Add APISIX implementation #843

merged 1 commit into from
Sep 2, 2021

Conversation

tao12345666333
Copy link
Member

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2021
robscott
robscott reviewed Aug 31, 2021
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this! LGTM other than one tiny nit.

site-src/implementations.md Outdated Show resolved Hide resolved
@robscott
Copy link
Member

Looks like a flake with the kind cluster.

/retest

jpeach
jpeach reviewed Aug 31, 2021
View reviewed changes
site-src/implementations.md Outdated Show resolved Hide resolved
@tao12345666333 @jpeach
Add Apache APISIX implementation
29b3354 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Co-authored-by: James Peach <jpeach@apache.org>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 2, 2021
@jpeach
Copy link
Contributor

jpeach commented Sep 2, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2021
@robscott
Copy link
Member

robscott commented Sep 2, 2021

Thanks @tao12345666333!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 11c196d into kubernetes-sigs:master Sep 2, 2021
@tao12345666333 tao12345666333 deleted the add-apisix-implementation branch September 2, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach left review comments

@hbagdi hbagdi Awaiting requested review from hbagdi

@robscott robscott Awaiting requested review from robscott

Assignees

@jpeach jpeach

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tao12345666333 @robscott @jpeach @k8s-ci-robot