Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate VolumeCapability matches with existing volume in Publish/Stage calls #253

Open
davidz627 opened this issue Apr 26, 2019 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@davidz627
Copy link
Contributor

We do static validation of volume capability now. However, if an existing volume is found we must validate that the volume capabilities of the existing volume match with the requested capabilities, otherwise we must return an "ALREADY_EXIST" error

@davidz627 davidz627 changed the title Validate VolumeCapability matches with "AlreadyExist"ing volume in Publish/Stage calls Validate VolumeCapability matches with existing volume in Publish/Stage calls Apr 26, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2019
@davidz627
Copy link
Contributor Author

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 26, 2019
@davidz627 davidz627 added this to the GA milestone Sep 18, 2019
@davidz627
Copy link
Contributor Author

For Publish and Stage we must validate that the VolumeCapability matches whether the volume is block or fs, then if fs that the actual fstype matches.

If requested VolumeCapability is block I don't think we can do any extra validation since a user could format their own fs onto the device and it technically is still block

@saad-ali
Copy link
Contributor

Removing this issue from GA blockers since the current behavior here is the same as the old in-tree behavior:

https://github.com/kubernetes/kubernetes/blob/aec30be5b3341d0937dc12e1d973cacb3714560e/pkg/volume/gcepd/gce_pd.go#L382-L384

While it would be nice to do stricter validation, this does not need to block GA.

@saad-ali saad-ali added this to the Post-GA milestone Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
4 participants