Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique object names in deployment #373

Closed
msau42 opened this issue Aug 14, 2019 · 1 comment · Fixed by #405
Closed

Unique object names in deployment #373

msau42 opened this issue Aug 14, 2019 · 1 comment · Fixed by #405
Assignees
@verult
Milestone
GA

Comments

@msau42
Copy link
Contributor

msau42 commented Aug 14, 2019

Some of the objects we create in the deployment manifests are cluster-wide. We should probably have more unique names for them. For example, our service account has a name like "csi-controller-sa" which when looking at it from the outside, you would have no idea it was for the pd csi driver (if you have multiple csi drivers on your system).
@msau42
Copy link
Contributor Author

msau42 commented Aug 14, 2019

/assign @verult

@davidz627 davidz627 added this to the GA milestone Sep 18, 2019
@verult verult mentioned this issue Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verult verult

Labels
None yet
Projects
None yet
Milestone
GA
3 participants
@verult @davidz627 @msau42