Make CSI Client more generic

[alexiondev]

By replacing the flag library with pflag, Volume Attributes and Secrets can be passed in instead of using specific flags: shareAddr, shareName, smbUsername and smbPassword.

The fields required in these maps are the exact same as required by the driver. Eg: in gcp-filestore-csi-driver, the volume attributes should have the fields "ip" and "volume".

Example usage:

.\csi-client.exe --endpoint "/tmp/csi.sock" --request "NodePublish" --volumeAttr "ip=localhost,volume=SMBShare" --targetPath "C:\mountedShare" --secrets "smbUser=foo\bar,smbPassword=foobar"

There's two things I'm still working on:

1. The usage isn't really working as it was before replacing flag library.
2. Commas (,) can't be passed in map keys or values and will cause an error.

[k8s-ci-robot]

Hi @almos98. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alexiondev]

/cc pjh msau42

[k8s-ci-robot]

@almos98: GitHub didn't allow me to request PR reviews from the following users: pjh.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc pjh msau42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pjh]

cc @pjh @adjackura

[msau42]

/ok-to-test

[alexiondev]

Fixed the usage message. Could you take a look @msau42 @pjh

[alexiondev]

I removed client_test.go as the only function it was testing has been removed (validateRequest).

Ready for review again @msau42 @pjh @adjackura

[pjh]

Some minor suggestions but overall LGTM

[msau42]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: almos98, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[msau42]

/lgtm
Thanks!