Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-639: Add labels from command line option to filestore backup resource #640

Merged
merged 1 commit into from
Apr 15, 2024
Merged

issue-639: Add labels from command line option to filestore backup resource #640

merged 1 commit into from
Apr 15, 2024

Conversation

bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented Oct 6, 2023 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Adds labels from command line option to the filestore backup resource. Adding this change would keep the labels behavior in uniform with what's supported for filestore instance resource.
Labels added by driver, user defined labels in StorageClass object and labels passed through command line are parsed with precedence in the listed order.

Which issue(s) this PR fixes:

Fixes #639

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @bharath-b-rh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2023
@bharath-b-rh
Copy link
Contributor Author

/cc @mattcary

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2024
@dobsonj
Copy link
Member

dobsonj commented Feb 8, 2024

IMO, this might just be considered a bug fix.
/lgtm
/ok-to-test
/assign @mattcary
for approval

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2024
@bharath-b-rh
Copy link
Contributor Author

/retest pull-gcp-filestore-csi-driver-kubernetes-integration

@k8s-ci-robot
Copy link
Contributor

@bharath-b-rh: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-gcp-filestore-csi-driver-e2e
  • /test pull-gcp-filestore-csi-driver-kubernetes-integration
  • /test pull-gcp-filestore-csi-driver-sanity
  • /test pull-gcp-filestore-csi-driver-unit
  • /test pull-gcp-filestore-csi-driver-verify

Use /test all to run all jobs.

In response to this:

/retest pull-gcp-filestore-csi-driver-kubernetes-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-b-rh
Copy link
Contributor Author

/test pull-gcp-filestore-csi-driver-kubernetes-integration

@bharath-b-rh
Copy link
Contributor Author

/test pull-gcp-filestore-csi-driver-e2e

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2024
@pwschuurman
Copy link
Contributor

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@pwschuurman
Copy link
Contributor

/approve

@bharath-b-rh
Copy link
Contributor Author

/cc @mattcary Could you please help with the PR.

@pwschuurman
Copy link
Contributor

/assign @leiyiz

Leiyi, can you take a look and approve?

leiyiz
leiyiz reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general looks good, will approve after comments are addressed.

pkg/csi_driver/controller_test.go
@@ -1678,6 +1735,7 @@ func TestCreateSnapshot(t *testing.T) {
Name: backupName,
Parameters: map[string]string{
util.VolumeSnapshotTypeKey: "backup",
ParameterKeyLabels: "key1:value1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this Line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had injected the parameter to check a scenario in the existing test case. I have updated it by adding a new test case for label scenario.

pkg/csi_driver/controller_test.go Outdated
@@ -1591,6 +1624,30 @@ func TestCreateSnapshot(t *testing.T) {
},
expectErr: true,
},
{
name: "Parameters contain misconfigured labels",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we be more specific on why the label is misconfigured

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion incorporated. Other test case names are updated as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leiyiz ^^

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
leiyiz
leiyiz reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, leiyiz, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 17578a7 into kubernetes-sigs:master Apr 15, 2024
7 checks passed
@bharath-b-rh bharath-b-rh deleted the issue-639 branch April 16, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwschuurman pwschuurman pwschuurman left review comments

@leiyiz leiyiz leiyiz left review comments

@tyuchn tyuchn Awaiting requested review from tyuchn

@mattcary mattcary Awaiting requested review from mattcary

Assignees

@pwschuurman pwschuurman

@dobsonj dobsonj

@mattcary mattcary

@leiyiz leiyiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add labels from command line option to filestore backup resource
6 participants
@bharath-b-rh @k8s-ci-robot @dobsonj @pwschuurman @leiyiz @mattcary