Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --output option to store logs in a file specified #2

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Add --output option to store logs in a file specified #2

merged 3 commits into from
Sep 26, 2022

Conversation

aniruddha2000
Copy link
Collaborator

What is this PR for -

  • Add functions for creating directory and file(pod name).
  • Add code that will write the logs in the file.

Other Minor changes -

  • Call the Cleanup function so that after done with logs it will clear the resources.

Test -

./bin/k8s-run-e2e --focus sig-auth --output conformance_log

@aniruddha2000
Add method for dir operation & write logs into the file
d873c47 
- Add stream logs struct
- Add func that will create the directory and file
- Add code that will get the logs and write into the file

Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@aniruddha2000
Use channels to send logs and errors
5b88210 
Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@aniruddha2000
Call cleanup to delete objects and remove printing args
d4bd755 
Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@aniruddha2000 aniruddha2000 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 26, 2022
@aniruddha2000 aniruddha2000 self-assigned this Sep 26, 2022
@dims dims merged commit f41c673 into main Sep 26, 2022
@dims dims mentioned this pull request Sep 26, 2022
Closed
@aniruddha2000 aniruddha2000 deleted the add-output-option branch September 29, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

Assignees

@aniruddha2000 aniruddha2000

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aniruddha2000 @dims